fix(specs): Increase optionalWords visibility in docs #4559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
should I wait for @kai687 's review or can I merge? |
|
@shortcuts Please merge. I just pinged Kai as an FYI. However, that "breaking changes" message is a little alarming! |
No worries on the breaking change message, it was for a previous PR! |
algolia-bot
added a commit
that referenced
this pull request
Mar 5, 2025
…ted) [skip ci] Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Mar 5, 2025
algolia/api-clients-automation#4559 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: gazconroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DOC-1573
Changes included:
In common/schemas/IndexSettings, moved the description text from
optionalWordsArraytooptionalWordsso that it’s visible when rendered by tools that are challenged by descriptions inoneOf(most of them)Also updated:
urlshould beuri-referencesince that allows relative URLsansweris 1,000 characters but the provided example was over 1,400 characters long